Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function
From: Logan Gunthorpe <logang@xxxxxxxxxxxx>
Date: Fri, 28 Apr 2017 10:53:45 -0600
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-crypto@xxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, intel-gfx@xxxxxxxxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-mmc@xxxxxxxxxxxxxxx, linux-nvdimm@xxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, open-iscsi@xxxxxxxxxxxxxxxx, megaraidlinux.pdl@xxxxxxxxxxxx, sparmaintainer@xxxxxxxxxx, devel@xxxxxxxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>, Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>, Sumit Semwal <sumit.semwal@xxxxxxxxxx>, Stephen Bates <sbates@xxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>
In-reply-to: <20170428063039.GB6817@gondor.apana.org.au>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 28/04/17 12:30 AM, Herbert Xu wrote:
> You are right.  Indeed the existing code looks buggy as they
> don't take sg->offset into account when doing the kmap.  Could
> you send me some patches that fix these problems first so that
> they can be easily backported?

Ok, I think the only buggy one in crypto is hifn_795x. Shash and caam
both do have the sg->offset accounted for. I'll send a patch for the
buggy one shortly.

Logan

Follow-Ups:
- Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function
  - From: Herbert Xu

References:
- [PATCH v2 00/21] Introduce common scatterlist map function
  - From: Logan Gunthorpe
- [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function
  - From: Logan Gunthorpe
- Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function
  - From: Herbert Xu
- Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function
  - From: Logan Gunthorpe
- Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function
  - From: Herbert Xu

Prev by Date: Re: em28xx module: misidentified card
Next by Date: Re: [PATCH 6/6] rc-core: add protocol to EVIOC[GS]KEYCODE_V2 ioctl
Previous by thread: Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function
Next by thread: Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function
Index(es):
- Date
- Thread

[Index of Archives] [Linux Input] [Video for Linux] [Gstreamer Embedded] [Mplayer Users] [Linux USB Devel] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]