Re: [PATCH] v4l2_subdev: rename tuner s_standby operation to core s_power

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Saturday 31 October 2009 10:13:22 Mauro Carvalho Chehab wrote:
> Em Mon, 12 Oct 2009 00:36:37 +0200
> 
> Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> escreveu:
> > On Monday 05 October 2009 15:48:17 Laurent Pinchart wrote:
> > > Upcoming I2C v4l2_subdev drivers need a way to control the subdevice
> > > power state from the core. This use case is already partially covered
> > > by the tuner s_standby operation, but no way to explicitly come back
> > > from the standby state is available.
> > >
> > > Rename the tuner s_standby operation to core s_power, and fix tuner
> > > drivers accordingly. The tuner core will call s_power(0) instead of
> > > s_standby(). No explicit call to s_power(1) is required for tuners as
> > > they are supposed to wake up from standby automatically.
> >
> > Mauro, Hans told me he didn't see anything wrong with this patch. As
> > there's no negative feedback so far (but unfortunately no positive
> > feedback either) can it be applied ?
> 
> It seems ok to me also. Not only tuner devices need to control power, so it
>  seems better to have this as a core operation instead of a tuner specific
>  one.
> 
> ACKED.
> 
> I've applied it at the tree, with a small codingstyle fix.
> 
> Hmm... mailimport script mangled the subject... I'll fix it on -git.

Thanks.

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux