Hi Mauro and Maxime, On Fri, Apr 21, 2017 at 12:11:05PM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 21 Apr 2017 16:41:25 +0200 > Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> escreveu: > > > On Wed, Apr 19, 2017 at 08:15:45AM -0300, Mauro Carvalho Chehab wrote: > > > Em Thu, 6 Apr 2017 16:40:51 +0200 > > > Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> escreveu: > > > > > > > The Makefiles were a free for all without a clear order defined. Sort all the > > > > options based on the Kconfig symbol. > > > > > > > > Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> > > > > > > > > --- > > > > > > > > Hi Mauro, > > > > > > > > Here is my makefile ordering patch again, this time with all the Makefiles > > > > in drivers/media that needed ordering. > > > > > > > > Since we're already pretty late in the release period, I guess there won't > > > > be any major conflicts between now and the merge window. > > > > > > > > > > The thing with patches like that is that they almost never apply fine. > > > By the time I review such patches, it was already broken. Also, > > > once applied, it breaks for everybody that have pending work to merge. > > > > > > This patch is broken (see attached). > > > > > > So, I prefer not applying stuff like that. > > > > I had the feeling that now would have been a good time to merge it, > > since all the PR should be merged I guess. But ok. > > No, there are drivers that were late-submitted, and whose commit > (if driver gets accepted) will be after -rc1. If this patch gets > applied, those drivers will have merge conflicts. There are also > the cases where people have drivers under development. If they pull > from my tree after a change like that, the developer will get > conflicts. Resolving a single conflict in a Makefile is certainly not unfeasible. Generally it'd be good to prioritise cleanups. When would it be a good time to get such changes in? Right in the beginning of the next merge window in media tree? -- Kind regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx
