On Fri, 30 Oct 2009, Karicheri, Muralidharan wrote: > Guennadi, > > > > mt9m111->rect.left = MT9M111_MIN_DARK_COLS; > > mt9m111->rect.top = MT9M111_MIN_DARK_ROWS; > >diff --git a/drivers/media/video/mt9t031.c b/drivers/media/video/mt9t031.c > >index 6966f64..57e04e9 100644 > >--- a/drivers/media/video/mt9t031.c > >+++ b/drivers/media/video/mt9t031.c > >@@ -301,9 +301,9 @@ static int mt9t031_set_params(struct soc_camera_device > >*icd, > > ret = reg_write(client, MT9T031_WINDOW_WIDTH, rect->width - 1); > > if (ret >= 0) > > ret = reg_write(client, MT9T031_WINDOW_HEIGHT, > >- rect->height + icd->y_skip_top - 1); > >+ rect->height - 1); > Why y_skip_top is removed? Because noone ever said they needed it? > When I connect the sensor output to our SOC > input and do format conversion and resize on the fly (frame by frame > conversion before writing to SDRAM) I have found that the frame > completion interrupt fails to get generated with zero value for > y_skip_top. I have used a value > of 10 and it worked fine for me. So I would like to have a > s_skip_top_lines() in the sensor operations which can be called to > update this value from the host/bridge driver. Hm, strange, that's actually not the purpose of this parameter. Wouldn't it work for you just as well, if you just request 10 more lines when sending s_fmt from your bridge driver? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
