On Wed, 2017-04-12 at 09:03 +0200, Hans Verkuil wrote: [...] > >> Do you have a git tree with this patch? It is really hard to review without > >> having the full imx-media-csi.c source. > > > > The patch applies on top of > > > > https://github.com/slongerbeam/mediatree.git imx-media-staging-md-v14 > > > > I have uploaded a branch > > > > git://git.pengutronix.de/git/pza/linux imx-media-staging-md-v14+color > > > > with the patch applied on top. > > > >> I think one problem is that it is not clearly defined how subdevs and colorspace > >> information should work. > > Ah, having the full source helped. > > Ignore my previous review, it was incorrect. Ok. > I'll have to think about this some more. I'll get back to this, but it may take some > time since my vacation starts tomorrow. The spec is simply unclear about how to handle > this so we have to come up with some guidelines. Yes, please. Until then, have a nice vacation. regards Philipp
