Hi Laurent, On Sat, Apr 08, 2017 at 01:10:47AM +0300, Sakari Ailus wrote: > Hi Laurent, > > On Fri, Apr 07, 2017 at 01:07:48PM +0300, Laurent Pinchart wrote: > > Hi Sakari, > > > > Thank you for the patch. > > > > On Thursday 06 Apr 2017 16:12:06 Sakari Ailus wrote: > > > OF and fwnode support are separated in V4L2 and individual drivers may > > > implement one of them. Sub-devices do not match with a notifier > > > expecting sub-devices with fwnodes, nor the other way around. > > > > Shouldn't we instead convert all drivers to fwnode matching ? What's missing > > after the mass conversion in patch 5/8 ? > > A lot of drivers use the OF frame work and thus do not deal with fwnodes > directly. I haven't entirely converted them to use the fwnode API since > making additional, unnecessary changes increases the likelihood of errors. Doing the rest of the conversion was less work than I originally had anticipated. The changes are obvious and very similar from driver to driver, perhaps unsurprisingly. Nevertheless, additional testing coverage certainly wouldn't hurt. -- Regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx
