Re: [PULL] http://linuxtv.org/hg/~mcisely/pvrusb2-20091011

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 29 Oct 2009, Mauro Carvalho Chehab wrote:

> Em Sun, 11 Oct 2009 22:53:14 -0500 (CDT)
> Mike Isely <isely@xxxxxxxxx> escreveu:
> 
> > 
> > Mauro:
> > 
> > Please from http://linuxtv.org/hg/~mcisely/pvrusb2-20091011 for a few 
> > various pvrusb2 fixes / improvements.  No critical bug fixes here, just 
> > a bunch of little things:
> > 
> > - pvrusb2: Make more info available to udev
> > - pvrusb2: Soften encoder warning message
> > - pvrusb2: Improve diagnostic info on driver initialization failure
> > - pvrusb2: Report hardware description to kernel log upon initialization
> > - pvrusb2: Add hardware description to debuginfo output
> > - pvrusb2: Fix redundant message on driver initialization failure (missing break)
> > - pvrusb2: Cosmetic kernel log tweak
> 
> Committed.
> 
> Please fix the existing CodingStyle erros added on this changeset on a next pull request:

We've had this discussion many times in the past.  I am not going to 
have that debate yet again.  These will NOT be changed.

  -Mike


> 
> ERROR: trailing statements should be on next line
> #26: FILE: linux/drivers/media/video/pvrusb2/pvrusb2-v4l2.c:919:
> +       if (!dip) return;
> +       if (!dip) return;
> ERROR: trailing statements should be on next line
> #27: FILE: linux/drivers/media/video/pvrusb2/pvrusb2-v4l2.c:920:
> +       if (!dip->devbase.parent) return;
> +       if (!dip->devbase.parent) return;
> 
> 
> 
> Cheers,
> Mauro
> 

-- 

Mike Isely
isely @ isely (dot) net
PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux