Em Tue, 27 Oct 2009 21:09:14 +0200 "Igor M. Liplianin" <liplianin@xxxxx> escreveu: > Mauro, > > Please pull from http://udev.netup.ru/hg/v4l-dvb-commits > > for the following 5 changesets: > > 01/05: stv6110: add configurable gain > http://udev.netup.ru/hg/v4l-dvb-commits?cmd=changeset;node=655c21f61eb3 > > 02/05: stv0900: fix diseqc support for NetUP card > http://udev.netup.ru/hg/v4l-dvb-commits?cmd=changeset;node=7682b35a0526 > > 03/05: stv0900: config definition for single/dual mode > http://udev.netup.ru/hg/v4l-dvb-commits?cmd=changeset;node=71fb9ae3e3f7 > > 04/05: stv0900 cut3.0 additions > http://udev.netup.ru/hg/v4l-dvb-commits?cmd=changeset;node=958ba6f1a1f8 > > 05/05: Change str snr scale for stv0900/903 and Netup Dual DVB-S2 card. > http://udev.netup.ru/hg/v4l-dvb-commits?cmd=changeset;node=5d0eb726d7cd > Igor, Patchset 04/05 introduces lots of CodingStyle errors/warnings, making harder to analise it. While on a few cases, it is ok to use more than 80 columns, on several cases it means that the logic is very complex and it would be better to reorganize the logic to be simpler (for example, creating some additional static functions. Please fix for me to better analise it. ... WARNING: line over 80 characters #166: FILE: linux/drivers/media/dvb/frontends/stv0900_core.c:1173: + stv0900_write_reg(i_params, R0900_P2_RTCS2, 0x44 ); WARNING: braces {} are not necessary for any arm of this statement #170: FILE: linux/drivers/media/dvb/frontends/stv0900_core.c:1177: + if (i_params->dmd2_symbol_rate <= 5000000) { [...] + } else { [...] WARNING: line over 80 characters #171: FILE: linux/drivers/media/dvb/frontends/stv0900_core.c:1178: + stv0900_write_reg(i_params, R0900_P2_RTCS2, 0x68 ); WARNING: line over 80 characters #173: FILE: linux/drivers/media/dvb/frontends/stv0900_core.c:1180: + stv0900_write_reg(i_params, R0900_P2_RTCS2, 0x44 ); WARNING: line over 80 characters #183: FILE: linux/drivers/media/dvb/frontends/stv0900_core.c:1190: + freq = (i_params->dmd2_srch_range / 2000 ) + 80; ... ERROR: Missing Signed-off-by: line(s) total: 1 errors, 219 warnings, 3303 lines checked Btw, you also missed to sign this patch. > > dvb/frontends/stv0900.h | 1 > dvb/frontends/stv0900_core.c | 306 ++++++++++++----- > dvb/frontends/stv0900_init.h | 63 +++ > dvb/frontends/stv0900_priv.h | 7 > dvb/frontends/stv0900_reg.h | 769 ++++++++++++++++--------------------------- > dvb/frontends/stv0900_sw.c | 669 ++++++++++++++++++++++--------------- > dvb/frontends/stv6110.c | 13 > dvb/frontends/stv6110.h | 1 > video/cx23885/cx23885-dvb.c | 11 > 9 files changed, 999 insertions(+), 841 deletions(-) > > Thanks, > Igor > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
