On Thu, 30 Mar 2017, Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx> wrote: > Currently, the script just assumes to be called at > Documentation/sphinx/. Change it to work on any directory, > and make it abort if something gets wrong. > > Also, be sure that both parameters are specified. > > That should avoid troubles like this: > > $ Documentation/sphinx/tmplcvt Documentation/DocBook/writing_usb_driver.tmpl > sed: couldn't open file convert_template.sed: No such file or directory > > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx> > --- > Documentation/sphinx/tmplcvt | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/Documentation/sphinx/tmplcvt b/Documentation/sphinx/tmplcvt > index 909a73065e0a..31df8eb7feca 100755 > --- a/Documentation/sphinx/tmplcvt > +++ b/Documentation/sphinx/tmplcvt > @@ -7,13 +7,22 @@ > # fix \_ > # title line? > # > +set -eu > + > +if [ "$2" == "" ]; then if [ "$#" != "2" ]; then otherwise with set -u you'll get unbound variable error if you don't provide $2. BR, Jani. > + echo "$0 <docbook file> <rst file>" > + exit > +fi > + > +DIR=$(dirname $0) > > in=$1 > rst=$2 > tmp=$rst.tmp > > cp $in $tmp > -sed --in-place -f convert_template.sed $tmp > +sed --in-place -f $DIR/convert_template.sed $tmp > pandoc -s -S -f docbook -t rst -o $rst $tmp > -sed --in-place -f post_convert.sed $rst > +sed --in-place -f $DIR/post_convert.sed $rst > rm $tmp > +echo "book writen to $rst" -- Jani Nikula, Intel Open Source Technology Center