Em Mon, 26 Oct 2009 21:24:03 +0800 KS Ng <ksnggm@xxxxxxxxx> escreveu: > This is a resend with the patch attached. > > KS Ng wrote: > > Hi, > > > > I've registered to linux-media mailing list a couple of days ago and > > attempted to do my first posting yesterday with subject "Support for > > Magicpro proHDTV Dual DMB-TH adapter". However I can't see my posting > > even though I've replied to the email requesting confirmation. > > > > Would you please kindly have a look! Please take a look at: http://linuxtv.org/hg/v4l-dvb/raw-file/tip/README.patches for some comments about how to submit a patch. Basically, you'll need to send a patch with a short description at the subject, a more complete description at the body and add your Signed-off-by: there. Also, please run checkpatch before submitting it, since it will point you the CodingStyle troubles that your code have. There are several coding styles there, being harder for people to analyse your code. In the case of tuner_init_pkts, is this a firmware or just register sets? If it is a firmware, it should be split from the code, due to legal issues. Basically, some lawyers believe that, if you distribute a firmware inside of the source code of a GPL'd code, you're bound to distribute also the firmware source code, due to GPL. Cheers, Mauro. > > > > Thanks, > > K.S. Ng > > > > email: ksnggm@xxxxxxxxx > Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
