Re: [PATCH v2 12/12] [media] ddbridge: support STV0367-based cards and modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Daniel,

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.11-rc3 next-20170324]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Daniel-Scheller/stv0367-ddbridge-support-CTv6-FlexCT-hardware/20170326-235957
base:   git://linuxtv.org/media_tree.git master
config: x86_64-rhel-7.2 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/media/pci/ddbridge/ddbridge-core.c: In function 'dvb_input_detach':
>> drivers/media/pci/ddbridge/ddbridge-core.c:891:3: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
      if (input->fe2)
      ^~
   drivers/media/pci/ddbridge/ddbridge-core.c:893:4: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
       input->fe2 = NULL;
       ^~~~~

vim +/if +891 drivers/media/pci/ddbridge/ddbridge-core.c

ccad0457 drivers/media/dvb/ddbridge/ddbridge-core.c Ralph Metzler   2011-07-03  875  }
ccad0457 drivers/media/dvb/ddbridge/ddbridge-core.c Ralph Metzler   2011-07-03  876  
ccad0457 drivers/media/dvb/ddbridge/ddbridge-core.c Ralph Metzler   2011-07-03  877  
ccad0457 drivers/media/dvb/ddbridge/ddbridge-core.c Ralph Metzler   2011-07-03  878  static void dvb_input_detach(struct ddb_input *input)
ccad0457 drivers/media/dvb/ddbridge/ddbridge-core.c Ralph Metzler   2011-07-03  879  {
ccad0457 drivers/media/dvb/ddbridge/ddbridge-core.c Ralph Metzler   2011-07-03  880  	struct dvb_adapter *adap = &input->adap;
ccad0457 drivers/media/dvb/ddbridge/ddbridge-core.c Ralph Metzler   2011-07-03  881  	struct dvb_demux *dvbdemux = &input->demux;
9f5af2d9 drivers/media/pci/ddbridge/ddbridge-core.c Daniel Scheller 2017-03-24  882  	struct i2c_client *client;
ccad0457 drivers/media/dvb/ddbridge/ddbridge-core.c Ralph Metzler   2011-07-03  883  
ccad0457 drivers/media/dvb/ddbridge/ddbridge-core.c Ralph Metzler   2011-07-03  884  	switch (input->attached) {
ccad0457 drivers/media/dvb/ddbridge/ddbridge-core.c Ralph Metzler   2011-07-03  885  	case 5:
9f5af2d9 drivers/media/pci/ddbridge/ddbridge-core.c Daniel Scheller 2017-03-24  886  		client = input->i2c_client[0];
9f5af2d9 drivers/media/pci/ddbridge/ddbridge-core.c Daniel Scheller 2017-03-24  887  		if (client) {
9f5af2d9 drivers/media/pci/ddbridge/ddbridge-core.c Daniel Scheller 2017-03-24  888  			module_put(client->dev.driver->owner);
9f5af2d9 drivers/media/pci/ddbridge/ddbridge-core.c Daniel Scheller 2017-03-24  889  			i2c_unregister_device(client);
9f5af2d9 drivers/media/pci/ddbridge/ddbridge-core.c Daniel Scheller 2017-03-24  890  		}
ccad0457 drivers/media/dvb/ddbridge/ddbridge-core.c Ralph Metzler   2011-07-03 @891  		if (input->fe2)
ccad0457 drivers/media/dvb/ddbridge/ddbridge-core.c Ralph Metzler   2011-07-03  892  			dvb_unregister_frontend(input->fe2);
9f5af2d9 drivers/media/pci/ddbridge/ddbridge-core.c Daniel Scheller 2017-03-24  893  			input->fe2 = NULL;
ccad0457 drivers/media/dvb/ddbridge/ddbridge-core.c Ralph Metzler   2011-07-03  894  		if (input->fe) {
ccad0457 drivers/media/dvb/ddbridge/ddbridge-core.c Ralph Metzler   2011-07-03  895  			dvb_unregister_frontend(input->fe);
ccad0457 drivers/media/dvb/ddbridge/ddbridge-core.c Ralph Metzler   2011-07-03  896  			dvb_frontend_detach(input->fe);
ccad0457 drivers/media/dvb/ddbridge/ddbridge-core.c Ralph Metzler   2011-07-03  897  			input->fe = NULL;
ccad0457 drivers/media/dvb/ddbridge/ddbridge-core.c Ralph Metzler   2011-07-03  898  		}
ccad0457 drivers/media/dvb/ddbridge/ddbridge-core.c Ralph Metzler   2011-07-03  899  	case 4:

:::::: The code at line 891 was first introduced by commit
:::::: ccad04578fcbe2678084af0986ac010ab84a023d [media] ddbridge: Initial check-in

:::::: TO: Ralph Metzler <rmetzler@xxxxxxxxxxxxxxxxx>
:::::: CC: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux