Re: [PATCH] staging: media: lirc: coding style fix use octal instead of symbolic permission

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 12, 2017 at 03:39:42PM +0900, Chetan Sethi wrote:
> This is a patch to the lirc_sir.c file that fixes coding style warning
> found by checkpatch.pl
> 
> Signed-off-by: Chetan Sethi <cpsethi369@xxxxxxxxx>

Another patch was merged which already fixed this, I'm sorry.

Sean

> ---
>  drivers/staging/media/lirc/lirc_sir.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/media/lirc/lirc_sir.c b/drivers/staging/media/lirc/lirc_sir.c
> index c75ae43..426753e 100644
> --- a/drivers/staging/media/lirc/lirc_sir.c
> +++ b/drivers/staging/media/lirc/lirc_sir.c
> @@ -826,14 +826,14 @@ MODULE_AUTHOR("Milan Pikula");
>  #endif
>  MODULE_LICENSE("GPL");
>  
> -module_param(io, int, S_IRUGO);
> +module_param(io, int, 0444);
>  MODULE_PARM_DESC(io, "I/O address base (0x3f8 or 0x2f8)");
>  
> -module_param(irq, int, S_IRUGO);
> +module_param(irq, int, 0444);
>  MODULE_PARM_DESC(irq, "Interrupt (4 or 3)");
>  
> -module_param(threshold, int, S_IRUGO);
> +module_param(threshold, int, 0444);
>  MODULE_PARM_DESC(threshold, "space detection threshold (3)");
>  
> -module_param(debug, bool, S_IRUGO | S_IWUSR);
> +module_param(debug, bool, 0644);
>  MODULE_PARM_DESC(debug, "Enable debugging messages");
> -- 
> 2.7.4



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux