Santiago Nunez-Corrales <snunez@xxxxxxxxxxxx> writes: > Kevin Hilman wrote: >> <santiago.nunez@xxxxxxxxxxxx> writes: >> >> >>> From: Santiago Nunez-Corrales <santiago.nunez@xxxxxxxxxxxx> >>> >>> This patch provides support for TVP7002 in architecture definitions >>> within DM365. >>> >>> Signed-off-by: Santiago Nunez-Corrales <santiago.nunez@xxxxxxxxxxxx> >>> --- >>> arch/arm/mach-davinci/board-dm365-evm.c | 170 ++++++++++++++++++++++++++++++- >>> 1 files changed, 166 insertions(+), 4 deletions(-) >>> >>> diff --git a/arch/arm/mach-davinci/board-dm365-evm.c b/arch/arm/mach-davinci/board-dm365-evm.c >>> index a1d5e7d..6c544d3 100644 >>> --- a/arch/arm/mach-davinci/board-dm365-evm.c >>> +++ b/arch/arm/mach-davinci/board-dm365-evm.c >>> @@ -38,6 +38,11 @@ >>> #include <mach/common.h> >>> #include <mach/mmc.h> >>> #include <mach/nand.h> >>> +#include <mach/gpio.h> >>> +#include <linux/videodev2.h> >>> +#include <media/tvp514x.h> >>> +#include <media/tvp7002.h> >>> +#include <media/davinci/videohd.h> >>> static inline int have_imager(void) >>> @@ -48,8 +53,11 @@ static inline int have_imager(void) >>> static inline int have_tvp7002(void) >>> { >>> - /* REVISIT when it's supported, trigger via Kconfig */ >>> +#ifdef CONFIG_VIDEO_TVP7002 >>> + return 1; >>> +#else >>> return 0; >>> +#endif >>> >> >> I've said this before, but I'll say it again. I don't like the >> #ifdef-on-Kconfig-option here. >> >> Can you add a probe hook to the platform_data so that when the tvp7002 >> is found it can call pdata->probe() which could then set a flag >> for use by have_tvp7002(). >> >> This will have he same effect without the ifdef since if the driver >> is not compiled in, its probe can never be triggered. >> >> Kevin >> >> > Kevin, > > I've been working on this particular implementation. This > board-dm365-evm.c is specific to the board, therefore I don't still > get the point of not having those values wired to the board file, but > I know it'd be nice to have the CPLD configuration triggered upon > TVP7002 detection. I see two options: Having them in the board file is appropriate, what I object to is the selection by Kconfig. Run-time detection is always preferred when possible. > 1. Do the callback function inside pdata and initialize it at driver > load time (tvp7002_probe). Set tvp5146 as default and override when > driver loads (and restore when unloads). This is the preferred option to me. > 2. Add an entry to sysfs such that it can be user-configurable whether > to activate one of the other regardless of whether tvp5156 or tvp7002 > are actually there (the only result would be fail to access the > device). Why do you need sysfs options for switching? Wouldn't building as modules and loading/unloading the needed modules serve the same purpose? Remeber that the 'probe' isn't going to be called until the platform_driver is registered, and that will (usually) happen at module load time. > Sneha, do you have any suggestions on this one? Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html