Re: [PATCH v2 03/15] media: s5p-mfc: Replace mem_dev_* entries with an array

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/22/2017 05:22 PM, Shuah Khan wrote:
On Mon, Feb 20, 2017 at 6:38 AM, Marek Szyprowski
<m.szyprowski@xxxxxxxxxxx> wrote:
Internal MFC driver device structure contains two pointers to devices used
for DMA memory allocation: mem_dev_l and mem_dev_r. Replace them with the
mem_dev[] array and use defines for accessing particular banks. This will
help to simplify code in the next patches.
Hi Marek,

The change looks good to me. One comment thought that it would be
good to keep the left and right banks in the driver code to be in sync
with the DT nomenclature.

BANK_L_CTX instead of BANK1_CTX
BANK_R_CTX instead of BANK2_CTX

This patch doesn't apply cleanly, could you please check and resend
rebased onto my for-v4.12/media/next branch?



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux