On Sun, 2017-03-12 at 16:13 -0400, Jérémy Lefaure wrote: > The driver uses kzalloc and kfree functions. So it should include > linux/slab.h. This header file is implicitly included by v4l2-common.h > if CONFIG_SPI is enabled. But when it is disabled, slab.h is not > included. In this case, the driver does not compile: > > drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c: In function ‘mtk_jpeg_open’: > drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1017:8: error: implicit > declaration of function ‘kzalloc’ > [-Werror=implicit-function-declaration] > ctx = kzalloc(sizeof(*ctx), GFP_KERNEL); > ^~~~~~~ > drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1017:6: warning: > assignment makes pointer from integer without a cast [-Wint-conversion] > ctx = kzalloc(sizeof(*ctx), GFP_KERNEL); > ^ > drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1047:2: error: implicit > declaration of function ‘kfree’ [-Werror=implicit-function-declaration] > kfree(ctx); > ^~~~~ > > This patch adds the missing include to fix this issue. > > Signed-off-by: Jérémy Lefaure <jeremy.lefaure@xxxxxxxxxxxx> > --- > drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 1 + > 1 file changed, 1 insertion(+) Acked-by: Rick Chang <rick.chang@xxxxxxxxxxxx>
