On Fri, Oct 23, 2009 at 9:35 AM, Sigmund Augdal <sigmund@xxxxxxx> wrote: > On Fri, Oct 23, 2009 at 12:10 AM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote: >> >>> The attach patch modifies v4l2-ctl -I to also output signal status as >>> detected by the driver/hardware. This info is available in the status >>> field of the data returned by VIDIOC_ENUMINPUT which v4l2-ctl -I >>> already calls. The strings are copied from the v4l2 api specification >>> and could perhaps be modified a bit to fit the application. >>> >>> Best regards >>> >>> Sigmund Augdal >>> >> >> Hi Sigmund, >> >> This doesn't work right: the status field is a bitmask, so multiple bits >> can be set at the same time. So a switch is not the right choice for that. >> Look at some of the other functions to print bitmasks in v4l2-ctl.cpp for >> ideas on how to implement this properly. >> >> But it will be nice to have this in v4l2-ctl! > Right, I realized this shortly after sending. I'll take a look at this > today. However, I'm unsure how to handle the value 0. It seems this is > used both for "signal detected and everything is ok" and "driver has > no clue if there is a signal or not". Any feedback welcome. Attached is my second attempt at this. It should be slightly cleaner. I also changed the output format a bit so the line containing input name is unchanged compared to current v4l2-ctl (in case anyone has scripts that depend on it). Now signal status is outputted on a new line. Best regards Sigmund Augdal > > Best regards > > Sigmund Augdal >> >> Regards, >> >> Hans >> >> -- >> Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom >> >> > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
