On 10/03/17 05:53, Steve Longerbeam wrote: > This adds a header file for use by userspace programs wanting to interact > with the i.MX media driver. It defines custom v4l2 controls for the > i.MX v4l2 subdevices. > > Signed-off-by: Steve Longerbeam <steve_longerbeam@xxxxxxxxxx> I would not export this while the imx driver is in staging. Also, traditionally exported media headers are in linux, not media. I would like to have a discussion about that before deciding where to place this header. For the record: I am not opposed to placing this in media. Regards, Hans > --- > include/uapi/media/Kbuild | 1 + > include/uapi/media/imx.h | 21 +++++++++++++++++++++ > 2 files changed, 22 insertions(+) > create mode 100644 include/uapi/media/imx.h > > diff --git a/include/uapi/media/Kbuild b/include/uapi/media/Kbuild > index aafaa5a..fa78958 100644 > --- a/include/uapi/media/Kbuild > +++ b/include/uapi/media/Kbuild > @@ -1 +1,2 @@ > # UAPI Header export list > +header-y += imx.h > diff --git a/include/uapi/media/imx.h b/include/uapi/media/imx.h > new file mode 100644 > index 0000000..f573de4 > --- /dev/null > +++ b/include/uapi/media/imx.h > @@ -0,0 +1,21 @@ > +/* > + * Copyright (c) 2014-2015 Mentor Graphics Inc. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by the > + * Free Software Foundation; either version 2 of the > + * License, or (at your option) any later version > + */ > + > +#ifndef __UAPI_MEDIA_IMX_H__ > +#define __UAPI_MEDIA_IMX_H__ > + > +enum imx_ctrl_id { > + V4L2_CID_IMX_FIM_ENABLE = (V4L2_CID_USER_IMX_BASE + 0), > + V4L2_CID_IMX_FIM_NUM, > + V4L2_CID_IMX_FIM_TOLERANCE_MIN, > + V4L2_CID_IMX_FIM_TOLERANCE_MAX, > + V4L2_CID_IMX_FIM_NUM_SKIP, > +}; > + > +#endif >