Re: [PATCH] coda: enable with COMPILE_TEST

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2017-03-08 at 12:52 +0100, Hans Verkuil wrote:
> Allow building of coda with COMPILE_TEST.
> 
> Fixed one v4l2_err format string that caused a compiler warning when compiling on a 64-bit
> platform.
> 
> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> ---
> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> index 53f6f12bff0d..9b9bee4b2323 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -151,7 +151,8 @@ if V4L_MEM2MEM_DRIVERS
> 
>   config VIDEO_CODA
>   	tristate "Chips&Media Coda multi-standard codec IP"
> -	depends on VIDEO_DEV && VIDEO_V4L2 && ARCH_MXC
> +	depends on VIDEO_DEV && VIDEO_V4L2
> +	depends on ARCH_MXC || COMPILE_TEST

Yes, that could be helpful.

Acked-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>

>   	depends on HAS_DMA
>   	select SRAM
>   	select VIDEOBUF2_DMA_CONTIG
> diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c
> index bd9e5ca8a640..5ec27626539e 100644
> --- a/drivers/media/platform/coda/coda-common.c
> +++ b/drivers/media/platform/coda/coda-common.c
> @@ -1407,7 +1407,7 @@ int coda_alloc_aux_buf(struct coda_dev *dev, struct coda_aux_buf *buf,
>   					GFP_KERNEL);
>   	if (!buf->vaddr) {
>   		v4l2_err(&dev->v4l2_dev,
> -			 "Failed to allocate %s buffer of size %u\n",
> +			 "Failed to allocate %s buffer of size %zu\n",
>   			 name, size);
>   		return -ENOMEM;
>   	}
> 

regards
Philipp




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux