Hi Sakari, Thanks for the patch. On 2016-11-08 12:11:15 +0200, Sakari Ailus wrote: > This way the pads are always passed to the has_route() op sink pad first. > Makes sense. > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > --- > Hi Niklas, > > This should make it easier to implement the has_route() op in drivers. > > Feel free to merge this to "[PATCH 02/32] media: entity: Add > media_entity_has_route() function" if you like, or add separately after > the second patch. I choose to append this as a separated patch on top of Laurents patches and include all 3 in my next R-Car VIN series. > > drivers/media/media-entity.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c > index 747adcb..520f3f6 100644 > --- a/drivers/media/media-entity.c > +++ b/drivers/media/media-entity.c > @@ -254,6 +254,10 @@ bool media_entity_has_route(struct media_entity *entity, unsigned int pad0, > if (!entity->ops || !entity->ops->has_route) > return true; > > + if (entity->pads[pad0].flags & MEDIA_PAD_FL_SOURCE > + && entity->pads[pad1].flags & MEDIA_PAD_FL_SINK) > + swap(pad0, pad1); > + > return entity->ops->has_route(entity, pad0, pad1); > } > EXPORT_SYMBOL_GPL(media_entity_has_route); > -- > 2.7.4 > -- Regards, Niklas Söderlund
