Re: [PATCH] [media] coda: restore original firmware locations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Philipp,

On Wed, Mar 01, 2017 at 04:36:25PM +0100, Philipp Zabel wrote:
> Recently, an unfinished patch was merged that added a third entry to the
> beginning of the array of firmware locations without changing the code
> to also look at the third element, thus pushing an old firmware location
> off the list.
> 
> Fixes: 8af7779f3cbc ("[media] coda: add Freescale firmware compatibility location")
> Cc: Baruch Siach <baruch@xxxxxxxxxx>
> Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>

Thanks for cleaning up after me.

Acked-by: Baruch Siach <baruch@xxxxxxxxxx>

[snip]

> -	if (dev->firmware == 1) {
> +	if (dev->firmware > 0) {
>  		/*
>  		 * Since we can't suppress warnings for failed asynchronous
>  		 * firmware requests, report that the fallback firmware was

I still think this is ugly, though.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@xxxxxxxxxx - tel: +972.52.368.4656, http://www.tkos.co.il -



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux