Re: [PATCH 4/6] omap3isp: Disable streaming at driver unbind time

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Laurent Pinchart wrote:
Hi Sakari,

Thank you for the patch.

On Monday 20 Feb 2017 17:22:20 Sakari Ailus wrote:
Once the driver is unbound accessing the hardware is not allowed anymore.
Due to this, disable streaming when the device driver is unbound. The
states of the associated objects related to Media controller and videobuf2
frameworks are updated as well, just like if the application disabled
streaming explicitly.

Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>

This looks mostly good to me, although I'm a bit concerned about race
conditions related to buffer handling. I don't think this patch introduces any
new one though, so

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

We'll have to go through buffer management at some point in the near future,
including from a V4L2 API point of view I think.

Thanks for the review!

Are you happy with me sending a pull request on the set, or would you prefer to pick the omap3isp patches? In the latter case I'll send a fix for the issue in the first patch.

--
Sakari Ailus
sakari.ailus@xxxxxxxxxxxxxxx



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux