On Fri, Oct 16, 2009 at 00:17:46, Kevin Hilman wrote:
> <santiago.nunez@xxxxxxxxxxxx> writes:
>
> > From: Santiago Nunez-Corrales <santiago.nunez@xxxxxxxxxxxx>
> >
> > This patch provides support for TVP7002 in architecture definitions
> > within DM365.
> >
> > Signed-off-by: Santiago Nunez-Corrales <santiago.nunez@xxxxxxxxxxxx>
> > ---
> > arch/arm/mach-davinci/board-dm365-evm.c | 170 ++++++++++++++++++++++++++++++-
> > 1 files changed, 166 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/mach-davinci/board-dm365-evm.c b/arch/arm/mach-davinci/board-dm365-evm.c
> > index a1d5e7d..6c544d3 100644
> > --- a/arch/arm/mach-davinci/board-dm365-evm.c
> > +++ b/arch/arm/mach-davinci/board-dm365-evm.c
> > @@ -38,6 +38,11 @@
> > #include <mach/common.h>
> > #include <mach/mmc.h>
> > #include <mach/nand.h>
> > +#include <mach/gpio.h>
> > +#include <linux/videodev2.h>
> > +#include <media/tvp514x.h>
> > +#include <media/tvp7002.h>
> > +#include <media/davinci/videohd.h>
> >
> >
> > static inline int have_imager(void)
> > @@ -48,8 +53,11 @@ static inline int have_imager(void)
> >
> > static inline int have_tvp7002(void)
> > {
> > - /* REVISIT when it's supported, trigger via Kconfig */
> > +#ifdef CONFIG_VIDEO_TVP7002
> > + return 1;
> > +#else
> > return 0;
> > +#endif
>
> I've said this before, but I'll say it again. I don't like the
> #ifdef-on-Kconfig-option here.
>
> Can you add a probe hook to the platform_data so that when the tvp7002
> is found it can call pdata->probe() which could then set a flag
> for use by have_tvp7002().
>
> This will have he same effect without the ifdef since if the driver
> is not compiled in, its probe can never be triggered.
But this wouldn't work when TVP7002 is built as a module. Correct?
The current patch does not take care of the module case as well.
Patch 6/6 of this series does seem to make the TVP7002 driver available
as module.
Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
