Fwd: [regression] dvb_usb_cxusb (was Re: ir-keytable: infinite loops, segfaults)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi list

I missed you in the cc: field...

---------- Forwarded message ----------
From: Vincent McIntyre <vincent.mcintyre@xxxxxxxxx>
Date: Thu, 16 Feb 2017 23:51:05 +1100
Subject: Re: [regression] dvb_usb_cxusb (was Re: ir-keytable: infinite
loops, segfaults)
To: Sean Young <sean@xxxxxxxx>

On 2/16/17, Sean Young <sean@xxxxxxxx> wrote:
>
> The problem is that DVB_USB_CXUSB Kconfig has this line:
>         select DVB_SI2168 if MEDIA_SUBDRV_AUTOSELECT
> The make_kconfig.pl script transforms this into a dependency, but
> DVB_SI2168 is only available when compiling against kernel 4.7 or later.
> I think only one select line needs to match, so I created this patch.
>
> Please apply this patch against media_build, you might need to do make
> clean before building again.

Awsome - build is working again, thank you. See the other thread for
my progress report.

> Thanks,
>
> Sean
>
>
> From: Sean Young <sean@xxxxxxxx>
> Date: Wed, 15 Feb 2017 14:58:00 +0000
> Subject: [PATCH] only one select Kconfig needs to match

Tested-by: vincent.mcintyre@xxxxxxxxx

> ---
>  v4l/scripts/make_kconfig.pl | 20 +++++++++++++++++++-
>  1 file changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/v4l/scripts/make_kconfig.pl b/v4l/scripts/make_kconfig.pl
> index ba8c134..a11f820 100755
> --- a/v4l/scripts/make_kconfig.pl
> +++ b/v4l/scripts/make_kconfig.pl
> @@ -169,6 +169,7 @@ sub depends($$)
>  	push @{$depends{$key}}, $deps;
>  }
>
> +my %selectdepends = ();
>  sub selects($$$)
>  {
>  	my $key = shift;
> @@ -181,7 +182,7 @@ sub selects($$$)
>  		# Transform "select X if Y" into "depends on !Y || X"
>  		$select = "!($if) || ($select)";
>  	}
> -	push @{$depends{$key}}, $select;
> +	push @{$selectdepends{$key}}, $select;
>  }
>
>  # Needs:
> @@ -228,6 +229,23 @@ sub checkdeps()
>  				return 0;
>  			}
>  		}
> +		my $selectdeps = $selectdepends{$key};
> +		if ($selectdeps) {
> +			my $found = 0;
> +			foreach (@$selectdeps) {
> +				next if($_ eq '');
> +				if (eval(toperl($_))) {
> +					$found = 1;
> +					last;
> +				}
> +			}
> +			if ($found == 0) {
> +				print "Disabling $key, select dependency '$_' not met\n" if $debug;
> +				$allconfig{$key} = 0;
> +				return 0;
> +			}
> +		}
> +
>  		return 1;
>  	}
>
> --
> 2.7.4

Vince



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux