On 02/14/2017 09:59 PM, Martin Herrman wrote: > All, > > I have a Cine CT V6.1 in my fedora 25 based media center. It is now > running a default fedora 4.9 kernel. I install the driver as follows: > > hg clone https://linuxtv.org/hg/~endriss/media_build_experimental I'm not sure what this media_build directory is. It certainly is outdated. The latest media_build is here: https://git.linuxtv.org/media_build.git/ > cd media_build_experimental > make download > make untar > make menuconfig > make > make install > > However, I have to make two changes to the source to make it work. > > Change 1: in media_build_experimental/v4l/Kconfig line 6936 I have to > remove the whitespace in '--- help ---', otherwise make menuconfig > fails. Can you show that line and the surrounding lines? I.e. the whole menu entry? > Change 2: during compilation the following error occurs (since about > kernel 4.5?): Most likely because the media build you use is outdated. > > make -C /lib/modules/4.9.7-201.fc25.x86_64/build > SUBDIRS=/home/htpc/Downloads/media_build_experimental/v4l modules > make[2]: Entering directory '/usr/src/kernels/4.9.7-201.fc25.x86_64' > CC [M] /home/htpc/Downloads/media_build_experimental/v4l/tuner-xc2028.o > In file included from <command-line>:0:0: > /home/htpc/Downloads/media_build_experimental/v4l/compat.h:1463:1: > error: redefinition of 'pci_zalloc_consistent' > pci_zalloc_consistent(struct pci_dev *hwdev, size_t size, > ^~~~~~~~~~~~~~~~~~~~~ > In file included from ./include/linux/pci.h:2145:0, > from > /home/htpc/Downloads/media_build_experimental/v4l/compat.h:1459, > from <command-line>:0: > ./include/linux/pci-dma-compat.h:23:1: note: previous definition of > 'pci_zalloc_consistent' was here > pci_zalloc_consistent(struct pci_dev *hwdev, size_t size, > ^~~~~~~~~~~~~~~~~~~~~ > In file included from <command-line>:0:0: > /home/htpc/Downloads/media_build_experimental/v4l/compat.h:1552:0: > warning: "DMA_ATTR_SKIP_CPU_SYNC" redefined > #define DMA_ATTR_SKIP_CPU_SYNC 0 > > In file included from ./include/linux/pci-dma-compat.h:7:0, > from ./include/linux/pci.h:2145, > from > /home/htpc/Downloads/media_build_experimental/v4l/compat.h:1459, > from <command-line>:0: > ./include/linux/dma-mapping.h:47:0: note: this is the location of the > previous definition > #define DMA_ATTR_SKIP_CPU_SYNC (1UL << 5) > > scripts/Makefile.build:299: recipe for target > '/home/htpc/Downloads/media_build_experimental/v4l/tuner-xc2028.o' > failed > make[3]: *** [/home/htpc/Downloads/media_build_experimental/v4l/tuner-xc2028.o] > Error 1 > Makefile:1494: recipe for target > '_module_/home/htpc/Downloads/media_build_experimental/v4l' failed > make[2]: *** [_module_/home/htpc/Downloads/media_build_experimental/v4l] Error 2 > make[2]: Leaving directory '/usr/src/kernels/4.9.7-201.fc25.x86_64' > Makefile:51: recipe for target 'default' failed > make[1]: *** [default] Error 2 > make[1]: Leaving directory '/home/htpc/Downloads/media_build_experimental/v4l' > Makefile:28: recipe for target 'all' failed > make: *** [all] Error 2 > > Which I fix by commenting out lines 1462 up to 1468 in > media_build_experimental/v4l/compat.h: > > //static inline void * > //pci_zalloc_consistent(struct pci_dev *hwdev, size_t size, > // dma_addr_t *dma_handle) > //{ > // return dma_alloc_coherent(hwdev == NULL ? NULL : &hwdev->dev, > // size, dma_handle, GFP_ATOMIC | __GFP_ZERO); > //} > > Now it compiles and works fine. I still get these warnings: > > media_build_experimental/v4l/compat.h:1552:0: warning: > "DMA_ATTR_SKIP_CPU_SYNC" redefined > #define DMA_ATTR_SKIP_CPU_SYNC 0 > > Which I can easily remove by commenting out the specific line as well. > > Now my questions are: > - is this the correct way to fix these compile errors? (I'm definately > not a professional developer) > - what can I do to have this solved in the source? > > Besides that, I'm also wondering if these drivers have any change of > getting into kernel mainline? Which driver? Regards, Hans
