Re: [PATCH v2 4/4] media-ctl: add colorimetry support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/13/2017 10:48 AM, Sakari Ailus wrote:
> Hi Hans,
> 
> On Mon, Feb 13, 2017 at 10:40:41AM +0100, Hans Verkuil wrote:
> ...
>>> @@ -839,6 +951,157 @@ enum v4l2_field v4l2_subdev_string_to_field(const char *string)
>>>  	return (enum v4l2_field)-1;
>>>  }
>>>  
>>> +static struct {
>>> +	const char *name;
>>> +	enum v4l2_colorspace colorspace;
>>> +} colorspaces[] = {
>>> +	{ "default", V4L2_COLORSPACE_DEFAULT },
>>> +	{ "smpte170m", V4L2_COLORSPACE_SMPTE170M },
>>> +	{ "smpte240m", V4L2_COLORSPACE_SMPTE240M },
>>> +	{ "rec709", V4L2_COLORSPACE_REC709 },
>>> +	{ "bt878", V4L2_COLORSPACE_BT878 },
>>
>> Drop this, it's no longer used in the kernel.
> 
> What about older kernels? Were there drivers that reported it?
> 

Possibly in a very distant past. But certainly not in anything supporting subdevs.

I looked into this when I worked on colorspaces and from what I could gather it
was based on a misunderstanding what a colorspace really is and it was just a
bogus 'colorspace'.

Regards,

	Hans



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux