Hi, Just to point it here - there is one more one-line correction needed below: On 11/14/2016 12:24 PM, Todor Tomov wrote: > The ov5645 sensor from Omnivision supports up to 2592x1944 > and CSI2 interface. > > The driver adds support for the following modes: > - 1280x960 > - 1920x1080 > - 2592x1944 > > Output format is packed 8bit UYVY. > > Signed-off-by: Todor Tomov <todor.tomov@xxxxxxxxxx> > --- > drivers/media/i2c/Kconfig | 12 + > drivers/media/i2c/Makefile | 1 + > drivers/media/i2c/ov5645.c | 1352 ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 1365 insertions(+) > create mode 100644 drivers/media/i2c/ov5645.c > <snip> > diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c > new file mode 100644 > index 0000000..2b33bc6 > --- /dev/null > +++ b/drivers/media/i2c/ov5645.c > @@ -0,0 +1,1352 @@ <snip> > +static int ov5645_entity_init_cfg(struct v4l2_subdev *subdev, > + struct v4l2_subdev_pad_config *cfg) > +{ > + struct v4l2_subdev_format fmt = { 0 }; > + struct ov5645 *ov5645 = to_ov5645(subdev); This variable is unused and should be removed. > + > + fmt.which = cfg ? V4L2_SUBDEV_FORMAT_TRY : V4L2_SUBDEV_FORMAT_ACTIVE; > + fmt.format.width = 1920; > + fmt.format.height = 1080; > + > + ov5645_set_format(subdev, cfg, &fmt); > + > + return 0; > +} <snip> -- Best regards, Todor Tomov -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html