RE: [Resubmition PATCH] Davinci VPFE Capture: Take i2c adapter id through platform data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Hiremath, Vaibhav
> Sent: Friday, October 16, 2009 3:57 PM
> To: linux-media@xxxxxxxxxxxxxxx
> Cc: davinci-linux-open-source@xxxxxxxxxxxxxxxxxxxx; Hiremath,
> Vaibhav
> Subject: [Resubmition PATCH] Davinci VPFE Capture: Take i2c adapter
> id through platform data
> 
> From: Vaibhav Hiremath <hvaibhav@xxxxxx>
> 
> The I2C adapter ID is actually depends on Board and may vary,
> Davinci
> uses id=1, but in case of AM3517 id=3.
> 
> Changes:
> 	- Fixed review comments (Typo) from Sergei
> 
> Signed-off-by: Vaibhav Hiremath <hvaibhav@xxxxxx>
> ---
>  drivers/media/video/davinci/vpfe_capture.c |    3 +--
>  include/media/davinci/vpfe_capture.h       |    2 ++
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/video/davinci/vpfe_capture.c
> b/drivers/media/video/davinci/vpfe_capture.c
> index dc32de0..c3c37e7 100644
> --- a/drivers/media/video/davinci/vpfe_capture.c
> +++ b/drivers/media/video/davinci/vpfe_capture.c
> @@ -2228,8 +2228,7 @@ static __init int vpfe_probe(struct
> platform_device *pdev)
>  	platform_set_drvdata(pdev, vpfe_dev);
>  	/* set driver private data */
>  	video_set_drvdata(vpfe_dev->video_dev, vpfe_dev);
> -	i2c_adap = i2c_get_adapter(1);
> -	vpfe_cfg = pdev->dev.platform_data;
> +	i2c_adap = i2c_get_adapter(vpfe_cfg->i2c_adapter_id);
>  	num_subdevs = vpfe_cfg->num_subdevs;
>  	vpfe_dev->sd = kmalloc(sizeof(struct v4l2_subdev *) *
> num_subdevs,
>  				GFP_KERNEL);
> diff --git a/include/media/davinci/vpfe_capture.h
> b/include/media/davinci/vpfe_capture.h
> index e8272d1..fc83d98 100644
> --- a/include/media/davinci/vpfe_capture.h
> +++ b/include/media/davinci/vpfe_capture.h
> @@ -94,6 +94,8 @@ struct vpfe_subdev_info {
>  struct vpfe_config {
>  	/* Number of sub devices connected to vpfe */
>  	int num_subdevs;
> +	/* I2C Bus adapter no */
> +	int i2c_adapter_id;
>  	/* information about each subdev */
>  	struct vpfe_subdev_info *sub_devs;
>  	/* evm card info */
[Hiremath, Vaibhav] Murali,

If you do not have any comments with these series of patches, can you please ack them?

Hans/Kevin,

Can you please merge these patches to respective repo., they should get applied cleanly.

Thanks,
Vaibhav

> --
> 1.6.2.4

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux