Re: [GIT PULL FOR v4.11] Add et8ek8 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mauro,

On Tue, Jan 31, 2017 at 10:42:48AM -0200, Mauro Carvalho Chehab wrote:
> That added a new warning:
> 
> drivers/media/i2c/et8ek8/et8ek8_driver.c: In function 'et8ek8_registered':
> drivers/media/i2c/et8ek8/et8ek8_driver.c:1262:29: warning: variable 'format' set but not used [-Wunused-but-set-variable]
>   struct v4l2_mbus_framefmt *format;
>                              ^~~~~~
> compilation succeeded
> 
> 
> The driver is calling this function and storing it on a var
> that is not used:
> 
>         format = __et8ek8_get_pad_format(sensor, NULL, 0,
>                                          V4L2_SUBDEV_FORMAT_ACTIVE);
>         return 0;
> 
> Please send a fixup patch.

I compiled it, too, but I guess I had a GCC version that didn't complain
about this particular matter. I'll send you a fix.

-- 
Cheers,

Sakari Ailus
e-mail: sakari.ailus@xxxxxx	XMPP: sailus@xxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux