On Fri, Jan 13, 2017 at 2:22 AM, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > Hi Matt, > > On Thursday 12 Jan 2017 20:45:21 Matt Ranostay wrote: >> On Sun, Jan 8, 2017 at 9:33 PM, Marek Vasut <marex@xxxxxxx> wrote: >> > On 01/09/2017 06:17 AM, Matt Ranostay wrote: >> >> Gentle ping on this! :) >> > >> > Just some high-level feedback ... You should use regmap instead. Also, >> > calling a driver which is specific to a particular sensor (amg88x) by >> > generic name (video_i2c) is probably not a good idea. >> >> There are likely going to variants, and other vendors that will have >> parts as well. One example to note is the FLIR Lepton, and that may be >> a good reason to use regmap in the future. Also Laurent suggested >> the generic naming :) > > I actually suggested video-i2c instead of i2c-polling to make the name *less* > generic :-) Ah misremembered, oops :). Although I think having it somewhat generic is ideal there are few of these sensors from various semiconductor companies which are pretty much basically the same. > >> >>> On Dec 23, 2016, at 19:04, Matt Ranostay <matt@ranostay.consulting> >> >>> wrote: >> >>> >> >>> There are several thermal sensors that only have a low-speed bus >> >>> interface but output valid video data. This patchset enables support >> >>> for the AMG88xx "Grid-Eye" sensor family. >> >>> >> >>> Cc: Attila Kinali <attila@xxxxxxxxx> >> >>> Cc: Marek Vasut <marex@xxxxxxx> >> >>> Cc: Luca Barbato <lu_zero@xxxxxxxxxx> >> >>> Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> >> >>> Signed-off-by: Matt Ranostay <matt@ranostay.consulting> >> >>> --- >> >>> Changes from v1: >> >>> * correct i2c_polling_remove() operations >> >>> * fixed delay calcuation in buffer_queue() >> >>> * add include linux/slab.h >> >>> >> >>> Changes from v2: >> >>> * fix build error due to typo in include of slab.h >> >>> >> >>> Changes from v3: >> >>> * switch data transport to a kthread to avoid to .buf_queue that can't >> >>> sleep * change naming from i2c-polling to video-i2c >> >>> * make the driver for single chipset under another uses the driver >> >>> >> >>> Changes from v4: >> >>> * fix wraparound issue with jiffies and schedule_timeout_interruptible() >> >>> >> >>> drivers/media/i2c/Kconfig | 9 + >> >>> drivers/media/i2c/Makefile | 1 + >> >>> drivers/media/i2c/video-i2c.c | 569 ++++++++++++++++++++++++++++++++++++ >> >>> 3 files changed, 579 insertions(+) >> >>> create mode 100644 drivers/media/i2c/video-i2c.c > > -- > Regards, > > Laurent Pinchart > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
