Hi Hans,
Thanks for the review.
> >>> On Wednesday 21 Dec 2016 08:10:37 Ramesh Shanmugasundaram wrote:
> >>>> Add binding documentation for Renesas R-Car Digital Radio Interface
> >>>> (DRIF) controller.
> >>>>
> >>>> Signed-off-by: Ramesh Shanmugasundaram
> >>>> <ramesh.shanmugasundaram@xxxxxxxxxxxxxx> ---
> >>>> .../devicetree/bindings/media/renesas,drif.txt | 202
> >> ++++++++++++++++++
> >>>> 1 file changed, 202 insertions(+)
> >>>> create mode 100644
> >>>> Documentation/devicetree/bindings/media/renesas,drif.txt
> >>>>
> >>>> diff --git
> >>>> a/Documentation/devicetree/bindings/media/renesas,drif.txt
> >>>> b/Documentation/devicetree/bindings/media/renesas,drif.txt new file
> >>>> mode
> >>>> 100644
> >>>> index 0000000..1f3feaf
> >>>> --- /dev/null
> >>>> +++ b/Documentation/devicetree/bindings/media/renesas,drif.txt
> >>
> >>>> +Optional properties of an internal channel when:
> >>>> + - It is the only enabled channel of the bond (or)
> >>>> + - If it acts as primary among enabled bonds
> >>>> +--------------------------------------------------------
> >>>> +- renesas,syncmd : sync mode
> >>>> + 0 (Frame start sync pulse mode. 1-bit width
> >> pulse
> >>>> + indicates start of a frame)
> >>>> + 1 (L/R sync or I2S mode) (default)
> >>>> +- renesas,lsb-first : empty property indicates lsb bit is
> received
> >>>> first.
> >>>> + When not defined msb bit is received first
> >>>> +(default)
> >>>> +- renesas,syncac-active: Indicates sync signal polarity, 0/1 for
> >> low/high
>
> Shouldn't this be 'renesas,sync-active' instead of syncac-active?
>
> I'm not sure if syncac is intended or if it is a typo.
Yes, "syncac" is intended. I kept the same name as in h/w manual for easy reference. Same for other properties - syncmd, dtdl & syncdl.
>
> >>>> + respectively. The default is 1 (active high)
> >>>> +- renesas,dtdl : delay between sync signal and start of
> >> reception.
> >>>> + The possible values are represented in 0.5
> clock
> >>>> + cycle units and the range is 0 to 4. The
> default
> >>>> + value is 2 (i.e.) 1 clock cycle delay.
> >>>> +- renesas,syncdl : delay between end of reception and sync
> >> signal
> >>>> edge.
> >>>> + The possible values are represented in 0.5
> clock
> >>>> + cycle units and the range is 0 to 4 & 6. The
> >> default
> >>>> + value is 0 (i.e.) no delay.
> >>>
> >>> Most of these properties are pretty similar to the video bus
> >>> properties defined at the endpoint level in
> >>> Documentation/devicetree/bindings/media/video-interfaces.txt. I
> >>> believe it would make sense to use OF graph and try to standardize
> >>> these properties similarly.
>
> Other than sync-active, is there really anything else that is similar? And
> even the sync-active isn't a good fit since here there is only one sync
> signal instead of two for video (h and vsync).
>
> Regards,
>
> Hans
>
Thanks,
Ramesh
��.n��������+%������w��{.n�����{��g����^n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�
