Hi Andi, Thank for your reminder. I will refine the code based on your work. to have elegant code and easy error handling. Sean On Fri, 2017-01-06 at 12:43 +0900, Andi Shyti wrote: > Hi Sean, > > > + ir->rc = rc_allocate_device(); > > Yes, you should use devm_rc_allocate_device(...) > > Besides, standing to this patch which is not in yet: > > https://lkml.org/lkml/2016/12/18/39 > > rc_allocate_device should provide the driver type during > allocation, so it should be: > > ir->rc = rc_allocate_device(RC_DRIVER_IR_RAW); > > and this line can be removed: > > > + ir->rc->driver_type = RC_DRIVER_IR_RAW; > > I don't know when Mauro will take the patch above. > > Andi -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
