Dear Guennadi
Thank you for checking patch
> Is this to tri-state the output? Ok, from the datasheet it tri-states all
> outputs except clocks. My copy of the datasheet is funny at this point. It
(snip)
> #define OEN_TRI_SEL_ALL_ON 0
> #define OEN_TRI_SEL_CLK_ON 4
OK
> Ok, it's 8:30 here, so, I might be still not quite awake... but I fail to
> understand, why you bother calculating val above if you anyway just return
(snip)
> dreaming. Oh, I see, you fix it in the next patch. Please, don't do that!
> Don't introduce bugs to fix them in a later patch. Do it here.
oh my god.
It is very buggy patch.
It seems to had broken while patch clean up
> While at it, could you also fix that typo copied from the datasheet:
> s/HSGEGIN/HSBEGIN/g?
OK
>> struct tw9910_video_info {
>> - unsigned long buswidth;
>> + u32 flags;
>> enum tw9910_mpout_pin mpout;
>> struct soc_camera_link link;
>> u16 start_offset;
>
>Hm, I am not convinced I liked all this. Do we understand what these
>configuration options are doing? Datasheet is not very verbose on that
>occasion. Is this configuration really platform-specific? What values have
>you found meaningful in which cases?
I need research about this.
I might have made a big mistake.
I should re-check my patches and consider all of your comment.
Thank you
Best regards
--
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
