Hi Shuah, [auto build test WARNING on v4.9-rc8] [cannot apply to linuxtv-media/master next-20161215] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Shuah-Khan/omap3-devm-usage-removal/20161216-111439 config: arm-omap2plus_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=arm All warnings (new ones prefixed by >>): drivers/media/platform/omap3isp/isp.c: In function 'isp_probe': >> drivers/media/platform/omap3isp/isp.c:2289:3: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (IS_ERR(isp->mmio_base[map_idx])) ^~ drivers/media/platform/omap3isp/isp.c:2291:4: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if' goto error_put_vdd_csiphy2; ^~~~ vim +/if +2289 drivers/media/platform/omap3isp/isp.c d8658bca drivers/media/platform/omap3isp/isp.c Laurent Pinchart 2012-09-27 2273 /* Clocks d8658bca drivers/media/platform/omap3isp/isp.c Laurent Pinchart 2012-09-27 2274 * d8658bca drivers/media/platform/omap3isp/isp.c Laurent Pinchart 2012-09-27 2275 * The ISP clock tree is revision-dependent. We thus need to enable ICLK d8658bca drivers/media/platform/omap3isp/isp.c Laurent Pinchart 2012-09-27 2276 * manually to read the revision before calling __omap3isp_get(). 8644cdf9 drivers/media/platform/omap3isp/isp.c Sakari Ailus 2015-03-25 2277 * 8644cdf9 drivers/media/platform/omap3isp/isp.c Sakari Ailus 2015-03-25 2278 * Start by mapping the ISP MMIO area, which is in two pieces. 8644cdf9 drivers/media/platform/omap3isp/isp.c Sakari Ailus 2015-03-25 2279 * The ISP IOMMU is in between. Map both now, and fill in the 8644cdf9 drivers/media/platform/omap3isp/isp.c Sakari Ailus 2015-03-25 2280 * ISP revision specific portions a little later in the 8644cdf9 drivers/media/platform/omap3isp/isp.c Sakari Ailus 2015-03-25 2281 * function. d8658bca drivers/media/platform/omap3isp/isp.c Laurent Pinchart 2012-09-27 2282 */ 8644cdf9 drivers/media/platform/omap3isp/isp.c Sakari Ailus 2015-03-25 2283 for (i = 0; i < 2; i++) { 8644cdf9 drivers/media/platform/omap3isp/isp.c Sakari Ailus 2015-03-25 2284 unsigned int map_idx = i ? OMAP3_ISP_IOMEM_CSI2A_REGS1 : 0; 8644cdf9 drivers/media/platform/omap3isp/isp.c Sakari Ailus 2015-03-25 2285 8644cdf9 drivers/media/platform/omap3isp/isp.c Sakari Ailus 2015-03-25 2286 mem = platform_get_resource(pdev, IORESOURCE_MEM, i); 8644cdf9 drivers/media/platform/omap3isp/isp.c Sakari Ailus 2015-03-25 2287 isp->mmio_base[map_idx] = 8644cdf9 drivers/media/platform/omap3isp/isp.c Sakari Ailus 2015-03-25 2288 devm_ioremap_resource(isp->dev, mem); 8644cdf9 drivers/media/platform/omap3isp/isp.c Sakari Ailus 2015-03-25 @2289 if (IS_ERR(isp->mmio_base[map_idx])) 27e86e5f drivers/media/platform/omap3isp/isp.c Shuah Khan 2016-12-15 2290 ret = PTR_ERR(isp->mmio_base[map_idx]); 27e86e5f drivers/media/platform/omap3isp/isp.c Shuah Khan 2016-12-15 2291 goto error_put_vdd_csiphy2; 8644cdf9 drivers/media/platform/omap3isp/isp.c Sakari Ailus 2015-03-25 2292 } 448de7e7 drivers/media/video/omap3isp/isp.c Sakari Ailus 2011-02-12 2293 448de7e7 drivers/media/video/omap3isp/isp.c Sakari Ailus 2011-02-12 2294 ret = isp_get_clocks(isp); 448de7e7 drivers/media/video/omap3isp/isp.c Sakari Ailus 2011-02-12 2295 if (ret < 0) 27e86e5f drivers/media/platform/omap3isp/isp.c Shuah Khan 2016-12-15 2296 goto error_put_vdd_csiphy2; 448de7e7 drivers/media/video/omap3isp/isp.c Sakari Ailus 2011-02-12 2297 :::::: The code at line 2289 was first introduced by commit :::::: 8644cdf972dd6dfebf98161025900f6a9d1ad58a [media] omap3isp: Replace many MMIO regions by two :::::: TO: Sakari Ailus <sakari.ailus@xxxxxx> :::::: CC: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
