Hi Shuah, Thank you for the patch. Sakari has submitted a similar patch as part of his kref series. Please use it as a base point and rework it if you want to get it merged separately. I've reviewed the patch and left quite a few comments that need to be addressed. On Thursday 15 Dec 2016 12:40:08 Shuah Khan wrote: > Using devm resources that have external dependencies such as a dev > for a file handler could result in devm resources getting released > durin unbind while an application has the file open holding pointer > to the devm resource. This results in use-after-free errors when the > application exits. > > Signed-off-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> > --- > drivers/media/platform/omap3isp/isp.c | 71 ++++++++++++++++-------- > drivers/media/platform/omap3isp/ispccp2.c | 10 +++- > drivers/media/platform/omap3isp/isph3a_aewb.c | 21 +++++--- > drivers/media/platform/omap3isp/isph3a_af.c | 21 +++++--- > drivers/media/platform/omap3isp/isphist.c | 5 +- > 5 files changed, 92 insertions(+), 36 deletions(-) -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html