Re: em28xx mode switching

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 12, 2009 at 6:31 PM, Antti Palosaari <crope@xxxxxx> wrote:
> I ran this same trap few weeks ago when adding Reddo DVB-C USB Box support
> to em28xx :) Anyhow, since it is dvb only device I decided to switch from
> .dvb_gpio to .tuner_gpio to fix the problem. I haven't pull requested it
> yet.
> http://linuxtv.org/hg/~anttip/reddo-dvb-c/rev/38f946af568f
>
> Antti
> --
> http://palosaari.fi/

You were able to get by with using tuner_gpio instead of dvb_gpio
because the Reddo isn't a hybrid device.

I'm going to propose removing the calls to em28xx_set_mode() in
start_streaming() and stop_streaming().  Given the supported boards
that are there, I can regression test:

EM2883_BOARD_HAUPPAUGE_WINTV_HVR_850
EM2883_BOARD_HAUPPAUGE_WINTV_HVR_950
EM2880_BOARD_PINNACLE_PCTV_HD_PRO
EM2880_BOARD_AMD_ATI_TV_WONDER_HD_600
EM2880_BOARD_HAUPPAUGE_WINTV_HVR_900
EM2880_BOARD_TERRATEC_HYBRID_XS

and I cannot regression test:

EM2880_BOARD_KWORLD_DVB_310U (I have a strong suspicion this board is
currently broken anyway)
EM2882_BOARD_TERRATEC_HYBRID_XS (I worked with the authors of this one
and can probably get them to test)
EM2882_BOARD_EVGA_INDTUBE (I worked with the authors of this one and
can probably get them to test)
EM2880_BOARD_EMPIRE_DUAL_TV (I worked with the authors of this one and
can probably get them to test)
EM2881_BOARD_PINNACLE_HYBRID_PRO (this is the board I noticed the problem under)
EM2883_BOARD_KWORLD_HYBRID_330U
EM2870_BOARD_REDDO_DVB_C_USB_BOX

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux