Em Fri, 9 Dec 2016 00:22:40 +0200 Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> escreveu: > Hello, > > This patch series fixes a regression reported by Devin Heitmueller that > affects a large number of em28xx. The problem was introduced by > > commit 13d52fe40f1f7bbad49128e8ee6a2fe5e13dd18d > Author: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx> > Date: Tue Jan 26 06:59:39 2016 -0200 > > [media] em28xx: fix implementation of s_stream > > that started calling s_stream(1) in the em28xx driver when enabling the > stream, resulting in the tvp5150 s_stream() operation writing several > registers with values fit for other platforms (namely OMAP3, possibly others) > but not for em28xx. > > The series starts with two unrelated drive-by cleanups and an unrelated bug > fix. It then continues with a patch to remove an unneeded and armful call to > tvp5150_reset() when getting the format from the subdevice (4/6), an update of > an invalid comment and the addition of macros for register bits in order to > make the code more readable (5/6) and actually allow following the incorrect > code flow, and finally a rework of the s_stream() operation to fix the > problem. > > I haven't been able to test this with an em28xx device as I don't own any. I > would appreciate if someone could give the series a go. > > Laurent Pinchart (6): > v4l: tvp5150: Compile tvp5150_link_setup out if > !CONFIG_MEDIA_CONTROLLER > v4l: tvp5150: Don't inline the tvp5150_selmux() function > v4l: tvp5150: Add missing break in set control handler > v4l: tvp5150: Don't reset device in get/set format handlers > v4l: tvp5150: Fix comment regarding output pin muxing > v4l: tvp5150: Don't override output pinmuxing at stream on/off time Tested here with an interlaced video input on S-Video and/or Composite entries of HVR-950: It broke Composite selection. After this series, only S-Video input works. VBI was not affected. Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
