On Thu, 8 Dec 2016, Laurent Pinchart wrote: > Hi Guennadi, > > On Thursday 08 Dec 2016 14:34:46 Guennadi Liakhovetski wrote: > > On Tue, 6 Dec 2016, Laurent Pinchart wrote: > > > On Tuesday 06 Dec 2016 11:39:22 Guennadi Liakhovetski wrote: > > >> On Tue, 6 Dec 2016, Laurent Pinchart wrote: > > >>> On Monday 05 Dec 2016 23:13:53 Guennadi Liakhovetski wrote: > > >>>> On Tue, 6 Dec 2016, Laurent Pinchart wrote: > > >>>>>>>> + /* > > >>>>>>>> + * Register a metadata node. TODO: shall this only be enabled > > >>>>>>>> for some > > >>>>>>>> + * cameras? > > >>>>>>>> + */ > > >>>>>>>> + if (!(dev->quirks & UVC_QUIRK_BUILTIN_ISIGHT)) > > >>>>>>>> + uvc_meta_register(stream); > > >>>>>>>> + > > >>>>>>> > > >>>>>>> I think so, only for the cameras that can produce metadata. > > >>>>>> > > >>>>>> Every UVC camera produces metadata, but most cameras only have > > >>>>>> standard fields there. Whether we should stream standard header > > >>>>>> fields from the metadata node will be discussed later. If we do > > >>>>>> decide to stream standard header fields, then every USB camera gets > > >>>>>> metadata nodes. If we decide not to include standard fields, how do > > >>>>>> we know whether the camera has any private fields in headers > > >>>>>> without streaming from it? Do you want a quirk for such cameras? > > >>>>> > > >>>>> Unless they can be detected in a standard way that's probably the > > >>>>> best solution. > > > > How about a module parameter with a list of VID:PID pairs? > > I'd like something that works out of the box for end-users, at least in most > cases. There's already a way to set quirks through a module parameter, and I > think I'd accept a patch extending that it make it VID:PID dependent. Ok, that helps already, sure. > That's > an acceptable solution for testing, but should not be considered as the way to > go for production. > > > The problem with the quirk is, that as vendors produce multiple cameras with > > different PIDs they will have to push patches for each such camera. > > How many such devices do you expect ? No idea, significantly more than 2, let's say :) But well, you already can count a few RealSense USB / UVC cameras on the market. Concerning metadata for isochronous endpoints. I actually don't know what to do with it. I don't have any such cameras with non-standard metadata. For the standard metadata it would probably be enough to get either the first or the last or the middle payload. Collecting all of them seems redundant to me. Maybe I could for now only enable metadata nodes for bulk endpoints. Would that be acceptable? Thanks Guennadi -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
