Hi Sakari,
Thank you for the patch.
On Friday 25 Nov 2016 15:55:43 Sakari Ailus wrote:
> Commit 3801bc7d1b8d ("[media] media: Media Controller fix to not let
> stream_count go negative") added a sanity check for negative stream_count,
> but a failure of the check remained silent. Make sure the failure is
> noticed.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/media-entity.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c
> index da46706..82dd0bc 100644
> --- a/drivers/media/media-entity.c
> +++ b/drivers/media/media-entity.c
> @@ -483,8 +483,8 @@ __must_check int __media_entity_pipeline_start(struct
> media_entity *entity, media_entity_graph_walk_start(graph, entity_err);
>
> while ((entity_err = media_entity_graph_walk_next(graph))) {
> - /* don't let the stream_count go negative */
> - if (entity_err->stream_count > 0) {
> + /* Sanity check for negative stream_count */
> + if (!WARN_ON_ONCE(entity_err->stream_count <= 0)) {
> entity_err->stream_count--;
> if (entity_err->stream_count == 0)
> entity_err->pipe = NULL;
> @@ -529,8 +529,8 @@ void __media_entity_pipeline_stop(struct media_entity
> *entity) media_entity_graph_walk_start(graph, entity);
>
> while ((entity = media_entity_graph_walk_next(graph))) {
> - /* don't let the stream_count go negative */
> - if (entity->stream_count > 0) {
> + /* Sanity check for negative stream_count */
> + if (!WARN_ON_ONCE(entity->stream_count <= 0)) {
> entity->stream_count--;
> if (entity->stream_count == 0)
> entity->pipe = NULL;
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
