Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> writes: > Hi Kevin, > > Thank you for the patch. > > On Tuesday 06 Dec 2016 21:08:24 Kevin Hilman wrote: >> Video capture subdevs may be over I2C and may sleep during xfer, so we >> cannot do IRQ-disabled locking when calling the subdev. >> >> The IRQ-disabled locking is meant to protect the DMA queue list >> throughout the rest of the driver, so update the locking in >> [start|stop]_streaming to protect just this list. >> >> Suggested-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> >> Signed-off-by: Kevin Hilman <khilman@xxxxxxxxxxxx> > > I would also add a comment to document the irqlock field as protecting the > dma_queue list only. Something like > > - /* Used in video-buf */ > + /* Protects the dma_queue field */ > spinlock_t irqlock; > > With that, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> OK, will update the comment. Thanks for the review, Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
