Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxxx> On Fri, Dec 02, 2016 at 05:16:09PM +0000, Sean Young wrote: > These ioctls should not succeed if the device cannot send. Also make it > clear that these ioctls should return the lirc mode, although the actual > value does not change. > > Signed-off-by: Sean Young <sean@xxxxxxxx> > --- > drivers/media/rc/ir-lirc-codec.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/rc/ir-lirc-codec.c b/drivers/media/rc/ir-lirc-codec.c > index c327730..9e41305 100644 > --- a/drivers/media/rc/ir-lirc-codec.c > +++ b/drivers/media/rc/ir-lirc-codec.c > @@ -204,11 +204,17 @@ static long ir_lirc_ioctl(struct file *filep, unsigned int cmd, > > /* legacy support */ > case LIRC_GET_SEND_MODE: > - val = LIRC_CAN_SEND_PULSE & LIRC_CAN_SEND_MASK; > + if (!dev->tx_ir) > + return -ENOTTY; > + > + val = LIRC_MODE_PULSE; > break; > > case LIRC_SET_SEND_MODE: > - if (val != (LIRC_MODE_PULSE & LIRC_CAN_SEND_MASK)) > + if (!dev->tx_ir) > + return -ENOTTY; > + > + if (val != LIRC_MODE_PULSE) > return -EINVAL; > return 0; > > -- > 2.9.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
