Just one question: On Tue, 6 Dec 2016, Laurent Pinchart wrote: > > >> + /* > > >> + * Register a metadata node. TODO: shall this only be enabled for some > > >> + * cameras? > > >> + */ > > >> + if (!(dev->quirks & UVC_QUIRK_BUILTIN_ISIGHT)) > > >> + uvc_meta_register(stream); > > >> + > > > > > > I think so, only for the cameras that can produce metadata. > > > > Every UVC camera produces metadata, but most cameras only have standard > > fields there. Whether we should stream standard header fields from the > > metadata node will be discussed later. If we do decide to stream standard > > header fields, then every USB camera gets metadata nodes. If we decide not > > to include standard fields, how do we know whether the camera has any > > private fields in headers without streaming from it? Do you want a quirk > > for such cameras? > > Unless they can be detected in a standard way that's probably the best > solution. Please remember that the UVC specification doesn't allow vendors to > extend headers in a vendor-specific way. Does it not? Where is that specified? I didn't find that anywhere. Thanks Guennadi -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
