On 2 December 2016 at 08:05, Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx> wrote: > Em Sun, 27 Nov 2016 12:11:48 +0100 > Marcel Hasler <mahasler@xxxxxxxxx> escreveu: > >> Allow setting a custom record gain for the internal AC97 codec (if available). This can be >> a value between 0 and 15, 8 is the default and should be suitable for most users. The Windows >> driver also sets this to 8 without any possibility for changing it. > > The problem of removing the mixer is that you need this kind of > crap to setup the volumes on a non-standard way. > Right, that's a good point. > NACK. > > Instead, keep the alsa mixer. The way other drivers do (for example, > em28xx) is that they configure the mixer when an input is selected, > increasing the volume of the active audio channel to 100% and muting > the other audio channels. Yet, as the alsa mixer is exported, users > can change the mixer settings in runtime using some alsa (or pa) > mixer application. > Yeah, the AC97 mixer we are currently leveraging exposes many controls that have no meaning in this device, so removing that still looks like an improvement. I guess the proper way is creating our own mixer (not using snd_ac97_mixer) exposing only the record gain knob. Marcel, what do you think? -- Ezequiel García, VanguardiaSur www.vanguardiasur.com.ar -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
