Hi Shailendra, Thank you for the patch, it's good for me. On 12/02/2016 05:48 AM, Shailendra Verma wrote: > The File handle is not yet added in the vdev list.So no need to call > v4l2_fh_del(&ctx->fh)if it fails to create control. > > Signed-off-by: Shailendra Verma <shailendra.v@xxxxxxxxxxx> Reviewed-by: Fabien Dessenne <fabien.dessenne@xxxxxx> > --- > drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c > index 45f82b5..fbf302f 100644 > --- a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c > +++ b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c > @@ -632,8 +632,8 @@ static int bdisp_open(struct file *file) > > error_ctrls: > bdisp_ctrls_delete(ctx); > -error_fh: > v4l2_fh_del(&ctx->fh); > +error_fh: > v4l2_fh_exit(&ctx->fh); > bdisp_hw_free_nodes(ctx); > mem_ctx: -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html