Re: [PATCH v4] media: video-i2c: add video-i2c driver

[kbuild test robot <lkp@xxxxxxxxx>]

Hi Matt,

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.9-rc6 next-20161125]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Matt-Ranostay/media-video-i2c-add-video-i2c-driver/20161126-144805
base:   git://linuxtv.org/media_tree.git master
config: x86_64-randconfig-x015-201648 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

   drivers/media/i2c/video-i2c.c: In function 'video_i2c_thread_vid_cap':
>> drivers/media/i2c/video-i2c.c:207:12: error: implicit declaration of function 'kthread_should_stop' [-Werror=implicit-function-declaration]
     } while (!kthread_should_stop());
               ^~~~~~~~~~~~~~~~~~~
   drivers/media/i2c/video-i2c.c: In function 'start_streaming':
>> drivers/media/i2c/video-i2c.c:219:26: error: implicit declaration of function 'kthread_run' [-Werror=implicit-function-declaration]
     data->kthread_vid_cap = kthread_run(video_i2c_thread_vid_cap, data,
                             ^~~~~~~~~~~
>> drivers/media/i2c/video-i2c.c:219:24: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
     data->kthread_vid_cap = kthread_run(video_i2c_thread_vid_cap, data,
                           ^
   drivers/media/i2c/video-i2c.c: In function 'stop_streaming':
>> drivers/media/i2c/video-i2c.c:253:2: error: implicit declaration of function 'kthread_stop' [-Werror=implicit-function-declaration]
     kthread_stop(data->kthread_vid_cap);
     ^~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/kthread_should_stop +207 drivers/media/i2c/video-i2c.c

   201				vb2_buffer_done(vb2_buf, ret ?
   202						VB2_BUF_STATE_ERROR : VB2_BUF_STATE_DONE);
   203			}
   204			spin_unlock(&data->slock);
   205	
   206			schedule_timeout_interruptible(delay - (jiffies - start_jiffies));
 > 207		} while (!kthread_should_stop());
   208	
   209		return 0;
   210	}
   211	
   212	static int start_streaming(struct vb2_queue *vq, unsigned int count)
   213	{
   214		struct video_i2c_data *data = vb2_get_drv_priv(vq);
   215	
   216		if (data->kthread_vid_cap)
   217			return 0;
   218	
 > 219		data->kthread_vid_cap = kthread_run(video_i2c_thread_vid_cap, data,
   220						    "%s-vid-cap", data->v4l2_dev.name);
   221	
   222		if (IS_ERR(data->kthread_vid_cap)) {
   223			struct video_i2c_buffer *buf, *tmp;
   224	
   225			list_for_each_entry_safe(buf, tmp, &data->vid_cap_active, list) {
   226				list_del(&buf->list);
   227				vb2_buffer_done(&buf->vb.vb2_buf,
   228						VB2_BUF_STATE_QUEUED);
   229			}
   230	
   231			return PTR_ERR(data->kthread_vid_cap);
   232		}
   233	
   234		return 0;
   235	}
   236	
   237	static void stop_streaming(struct vb2_queue *vq)
   238	{
   239		struct video_i2c_data *data = vb2_get_drv_priv(vq);
   240	
   241		if (data->kthread_vid_cap == NULL)
   242			return;
   243	
   244		while (!list_empty(&data->vid_cap_active)) {
   245			struct video_i2c_buffer *buf;
   246	
   247			buf = list_entry(data->vid_cap_active.next,
   248					 struct video_i2c_buffer, list);
   249			list_del(&buf->list);
   250			vb2_buffer_done(&buf->vb.vb2_buf, VB2_BUF_STATE_ERROR);
   251		}
   252	
 > 253		kthread_stop(data->kthread_vid_cap);
   254		data->kthread_vid_cap = NULL;
   255	}
   256	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip