Hi, On 22/11/16 13:09, Mauro Carvalho Chehab wrote: > When compiled on i386, it produces several warnings: > > ./arch/x86/include/asm/bitops.h:457:22: warning: asm output is not an lvalue > ./arch/x86/include/asm/bitops.h:457:22: warning: asm output is not an lvalue > ./arch/x86/include/asm/bitops.h:457:22: warning: asm output is not an lvalue > ./arch/x86/include/asm/bitops.h:457:22: warning: asm output is not an lvalue > ./arch/x86/include/asm/bitops.h:457:22: warning: asm output is not an lvalue > ./arch/x86/include/asm/bitops.h:457:22: warning: asm output is not an lvalue > > I suspect that some gcc optimization could be causing the asm code to be > incorrectly generated. Splitting it into two macro calls fix the issues > and gets us rid of 6 smatch warnings, with is a good thing. As it should > not cause any troubles, as we're basically doing the same thing, let's > apply such change to vpe.c. > > Cc: Benoit Parrot <bparrot@xxxxxx> > Cc: Hans Verkuil <hans.verkuil@xxxxxxxxx> > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx> > --- > drivers/media/platform/ti-vpe/vpe.c | 18 +++++++++++++++--- > 1 file changed, 15 insertions(+), 3 deletions(-) I think the point of COMPILE_TEST is to improve the quality of the code. This patch doesn't improve the quality, on the contrary. If those warnings on a (buggy?) i386 gcc are a problem, I suggest removing COMPILE_TEST for vpe. Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
