On 08/11/16 14:55, Sakari Ailus wrote:
The struct device of the media device driver (i.e. not that of the media
devnode) is pointed to by the media device. The struct device pointer is
mostly used for debug prints.
Ensure it will stay around as long as the media device does.
Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
---
drivers/media/media-device.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
index 2e52e44..648c64c 100644
--- a/drivers/media/media-device.c
+++ b/drivers/media/media-device.c
@@ -724,6 +724,7 @@ static void media_device_release(struct media_devnode *devnode)
mdev->entity_internal_idx_max = 0;
media_entity_graph_walk_cleanup(&mdev->pm_count_walk);
mutex_destroy(&mdev->graph_mutex);
+ put_device(mdev->dev);
kfree(mdev);
}
@@ -732,9 +733,15 @@ struct media_device *media_device_alloc(struct device *dev)
{
struct media_device *mdev;
+ dev = get_device(dev);
+ if (!dev)
+ return NULL;
I don't think this is right. When you allocate the media_device struct
it should
just be initialized, but not have any side effects until it is actually
registered.
When the device is registered the device_add call will increase the parent's
refcount as it should, thus ensuring it stays around for as long as is
needed.
Regards,
Hans
+
mdev = kzalloc(sizeof(*mdev), GFP_KERNEL);
- if (!mdev)
+ if (!mdev) {
+ put_device(dev);
return NULL;
+ }
mdev->dev = dev;
media_device_init(mdev);
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
