Arnd Bergmann <arnd@xxxxxxxx> writes: > On Friday, November 18, 2016 4:32:08 PM CET Kevin Hilman wrote: >> + >> +Required properties: >> +- compatible: must be "ti,vpif-capture" >> +- reg: physical base address and length of the registers set for the device; >> +- interrupts: should contain IRQ line for the VPIF >> + >> > > Shouldn't this have a SoC specific identifier or a version number > in the compatible string? "vpif" seems rather generic, so it's > likely that TI made more than one variant of it. AFAICT, they used this for a single generation of davinci SoCs (dm6467, da850) and then moved on to using something completely different. But, that still proves your point because it's very SoC specific, so I'll make the compatible specific. Thanks for the review, Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
