Re: [PATCH 1/1] v4l: videodev2: Include linux/time.h for timeval and timespec structs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Em Mon, 21 Nov 2016 15:51:56 +0200
Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> escreveu:

> Hi Mauro,
> 
> On 11/21/16 15:33, Mauro Carvalho Chehab wrote:
> > Em Thu, 27 Oct 2016 13:50:51 +0300
> > Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> escreveu:
> >   
> >> struct timeval and struct timespec are defined in linux/time.h. Explicitly
> >> include the header if __KERNEL__ is defined.  
> > 
> > The patch below doesn't do what you're mentioned above. It unconditionally
> > include linux/time.h, and, for userspace, it will *also* include
> > sys/time.h...  
> 
> My bad... I thought writing a single line patch would be easy. ;-) Will fix.
> 
> > 
> > I suspect that this would cause problems on userspace.
> > 
> > Btw, you didn't mention on your description what's the bug you're
> > trying to fix.  
> 
> The problem is a compiler error due to lacking defition for a struct.
> I'll add that to v2.

On userspace or Kernelspace? Please be clear at version 2, adding the
relevant info about how you got it.


Thanks,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux