Hi! > > + /* V4L2_CID_EXPOSURE */ > > + min = et8ek8_exposure_rows_to_us(sensor, 1); > > + max = et8ek8_exposure_rows_to_us(sensor, > > + sensor->current_reglist->mode.max_exp); > > Haven't I suggested to use lines instead? I vaguely remember doing so... > this would remove quite some code from the driver. Lines ... lines ... no, I don't think I understand how to use lines here. I guess I could switch units from us to rows here...? Is it good idea? For userspace, microseconds are really a nice interface, because ... well, that's what photographers are used to think about (ISO 400, time 1/100). fcam also uses usec internally. In the current camera code, I do autogain in small resolution, then use same parameters (gain, time) at higher resolution. I guess I could do the same with the non-microseconds interface, but then I'd have to move the microsecond computation into userspace. And userspace is not really good place to do that, as it does not know (and should not have to know!) such low level details. So... can we keep the interface as it is? Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
