Thanks for your hard work at beautification of this driver :)
>From reviewing the diff over v1, it looks good.
Also thanks for deep explanations you gave me for my comments.
On Sat, Nov 19, 2016 at 07:27:30PM -0200, Mauro Carvalho Chehab wrote:
>
> Suggested-by: Andrey Utkin <andrey_utkin@xxxxxxxxxxxx>
> Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
> Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx>
> ---
Reviewed-by: Andrey Utkin <andrey_utkin@xxxxxxxxxxxx>
> --- a/drivers/media/pci/cx88/cx88-input.c
> +++ b/drivers/media/pci/cx88/cx88-input.c
> @@ -62,11 +62,15 @@ static int ir_debug;
> module_param(ir_debug, int, 0644); /* debug level [IR] */
> MODULE_PARM_DESC(ir_debug, "enable debug messages [IR]");
>
> -#define ir_dprintk(fmt, arg...) if (ir_debug) \
> - printk(KERN_DEBUG "%s IR: " fmt, ir->core->name, ##arg)
> +#define ir_dprintk(fmt, arg...) do { \
> + if (ir_debug) \
> + printk(KERN_DEBUG "%s IR: " fmt, ir->core->name, ##arg);\
> +} while (0)
Oh ok, so when the patch is applied, the backslash doesn't stand out, it
just looks this way in the diff.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
